Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try eventemitter3 #210

Merged
merged 2 commits into from
Mar 18, 2024
Merged

chore: try eventemitter3 #210

merged 2 commits into from
Mar 18, 2024

Conversation

bumi
Copy link
Contributor

@bumi bumi commented Mar 6, 2024

as the events package does not play nicely in a module import setup this is an alternative.

https://www.npmjs.com/package/eventemitter3

as the events package does not play nicely in a module import setup
@bumi bumi requested a review from rolznz March 6, 2024 22:56
Copy link

socket-security bot commented Mar 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/domelementtype@2.3.0 None 0 11.4 kB feedic
npm/es-abstract@1.20.4 Transitive: eval +30 3.2 MB ljharb
npm/graceful-fs@4.2.11 environment, filesystem 0 32.5 kB isaacs
npm/has-bigints@1.0.2 None 0 12.8 kB ljharb
npm/is-callable@1.2.7 None 0 28.9 kB ljharb
npm/is-docker@2.2.1 filesystem 0 3.01 kB sindresorhus
npm/is-string@1.0.7 None 0 19.1 kB ljharb
npm/is-symbol@1.0.4 None +1 42.6 kB ljharb
npm/object-inspect@1.12.2 None 0 93.6 kB ljharb
npm/regexp.prototype.flags@1.4.3 Transitive: eval +9 200 kB ljharb

🚮 Removed packages: npm/graceful-fs@4.2.10, npm/jest-util@29.5.0, npm/pretty-format@29.5.0

View full report↗︎

Copy link

socket-security bot commented Mar 6, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz
Copy link
Contributor

rolznz commented Mar 14, 2024

@pavanjoshi914 any chance you can check this works with the extension, and if so make a patch release of js-sdk and consume the new version in the extension?

@pavanjoshi914
Copy link
Contributor

looks good! able to receive tokens via event

image

@pavanjoshi914 pavanjoshi914 merged commit 23a5965 into master Mar 18, 2024
3 checks passed
@pavanjoshi914 pavanjoshi914 deleted the eventemitter3 branch March 18, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants