-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: try eventemitter3 #210
Conversation
as the events package does not play nicely in a module import setup
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/graceful-fs@4.2.10, npm/jest-util@29.5.0, npm/pretty-format@29.5.0 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@pavanjoshi914 any chance you can check this works with the extension, and if so make a patch release of js-sdk and consume the new version in the extension? |
as the events package does not play nicely in a module import setup this is an alternative.
https://www.npmjs.com/package/eventemitter3