Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add liquid #2467

Merged
merged 61 commits into from
Aug 12, 2023
Merged

feat: add liquid #2467

merged 61 commits into from
Aug 12, 2023

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

Extends the mnemonic for use in liquid btc.

Link this PR to an issue [optional]

Fixes #2074

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

How has this been tested?

Manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

rolznz
rolznz approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

rolznz
rolznz reviewed Jun 12, 2023
View reviewed changes
src/common/lib/mnemonic.ts Outdated Show resolved Hide resolved
rolznz
rolznz reviewed Jun 12, 2023
View reviewed changes
src/common/lib/mnemonic.ts Outdated Show resolved Hide resolved
@im-adithya im-adithya mentioned this pull request Jun 14, 2023
Merged
@im-adithya im-adithya mentioned this pull request Jun 16, 2023
Closed
3 tasks
Base automatically changed from feat/mnemonic to master June 30, 2023 05:43
rolznz
rolznz reviewed Aug 1, 2023
View reviewed changes
src/common/lib/esplora.ts Outdated Show resolved Hide resolved
reneaaron
reneaaron reviewed Aug 1, 2023
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
rolznz
rolznz reviewed Aug 1, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
rolznz
rolznz approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

bumi
bumi reviewed Aug 8, 2023
View reviewed changes
src/app/screens/Liquid/ConfirmSignPset.tsx Outdated Show resolved Hide resolved
src/app/screens/Liquid/ConfirmSignPset.tsx Outdated Show resolved Hide resolved
src/app/screens/Liquid/ConfirmSignPset.tsx Outdated Show resolved Hide resolved
@bumi bumi merged commit e2a87ac into master Aug 12, 2023
5 of 6 checks passed
@bumi bumi deleted the task-liquid-mnemonic branch August 12, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumi bumi bumi left review comments

@rolznz rolznz rolznz approved these changes

@louisinger louisinger louisinger approved these changes

@pavanjoshi914 pavanjoshi914 pavanjoshi914 left review comments

@reneaaron reneaaron Awaiting requested review from reneaaron

Assignees

@rolznz rolznz

@im-adithya im-adithya

Labels
None yet
Projects
🐝 Alby
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Signing functionality for Liquid
6 participants
@im-adithya @louisinger @bumi @rolznz @pavanjoshi914 @reneaaron