Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return to home when switching accounts #2481

Merged

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

Takes you to / when switching between accounts.

Pro:

  • Clean start after switching accounts (no broken behavior e.g. when switching accounts on the receive page with the QR code and polling for invoice updates)

Contra:

  • If you switch accounts on all other pages you first have to navigate there again (e.g. when you notice that you have selected the wrong account on the send page)

@reneaaron reneaaron linked an issue Jun 14, 2023 that may be closed by this pull request
1 task
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

@bumi
Copy link
Collaborator

bumi commented Jun 14, 2023

+1

but I think this is a problem in the prompt, there we should not navigate

@stackingsaunter
Copy link
Contributor

  • If you switch accounts on all other pages you first have to navigate there again (e.g. when you notice that you have selected the wrong account on the send page)

This is a bit unfortunate, I personally used switch while login in or sending a few times. I think I never switch receiving request.

@reneaaron
Copy link
Contributor Author

Yes, switching in prompts is especially useful (you noticed that you are on the wrong account while you authenticate, pay, etc). I think this has to be limited to only non-prompt usages.

@reneaaron reneaaron marked this pull request as ready for review July 22, 2023 11:25
@reneaaron reneaaron requested a review from bumi July 24, 2023 07:11
@reneaaron reneaaron merged commit e518a13 into master Jul 26, 2023
5 of 6 checks passed
@reneaaron reneaaron deleted the 2463-bug-return-to-home-screen-when-switching-accounts branch July 26, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Return to home screen when switching accounts
3 participants