feat: onchain swaps #2514
Merged
feat: onchain swaps #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. Don't forget: keep earning sats! |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: alby-js-sdk@2.1.2 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
bumi
reviewed
Aug 16, 2023
This reverts commit 7494a47.
reneaaron
commented
Aug 21, 2023
| @@ -924,7 +951,7 @@ | |||
| "pasted": "Pasted!", | |||
| "description": "Description", | |||
| "description_full": "Full Description", | |||
| "success_message": "{{amount}}{{fiatAmount}} sent to {{destination}}", | |||
| "success_message": "{{amount}}{{fiatAmount}} are on their way to {{destination}}", | |||
There was a problem hiding this comment.
@rolznz Did you change the default message that is being used everywhere on purpose? Should we add a separate success message for that?
bumi
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Sending to onchain addresses.