Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add chrome prod pubkey to manifest json #2581

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jul 20, 2023

Ensures production builds always have the same extension ID

This wasn't the case when loading an unpacked extension (e.g. nightly build)

Manually tested locally by importing an unpacked production extension build (built locally).

Note: this public key is freely available (included in extension folder e.g.

C:\Users\MyUsername\AppData\Local\Google\Chrome\User Data\Default\Extensions\iokeahhehimjnekafflcihljlcjccdbe\2.1.1_0\manifest.json

Ensures production builds always have the same extension ID

This wasn't the case when loading an unpacked extension (e.g. nightly build)
@rolznz rolznz requested a review from reneaaron July 20, 2023 15:09
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

utACK

@reneaaron reneaaron merged commit 051682b into master Jul 24, 2023
5 of 6 checks passed
@reneaaron reneaaron deleted the fix/manifest-chrome-prod-key branch July 24, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants