Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make alby connector init consistent with other connectors #2584

Merged
merged 3 commits into from
Jul 24, 2023
Merged

fix: make alby connector init consistent with other connectors #2584

merged 3 commits into from
Jul 24, 2023

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jul 21, 2023

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

reneaaron
reneaaron approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. utACK

@bumi bumi merged commit cfe88c5 into master Jul 24, 2023
5 of 6 checks passed
@bumi bumi deleted the fix/alby-connector-init branch July 24, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron approved these changes

@bumi bumi Awaiting requested review from bumi

@pavanjoshi914 pavanjoshi914 Awaiting requested review from pavanjoshi914

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolznz @reneaaron @bumi