fix: made the QR code scannable for even shorter lightning addresses #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
The QR code in the receive screen is not scannable when the lightning address name is <=3 characters. The issue might be due to the addition of avatar on the QR code. Few changes to fix this issue might be - increase the QR size, decrease the avatar size, Increase the error correction.
I increased the EC level as this seemed to be the best approach for it.
Link this PR to an issue
Fixes #2774
Type of change
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
These are few lightning addresses which can be used to test whether the QR is working after this change(hardcoded).
How has this been tested?
Hardcoded the lightning address and checked whether it is working for lightning addresses with less than three characters.
Checklist