-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linear min & max sats buttons #2803
base: master
Are you sure you want to change the base?
Conversation
can you please try and fix code quality checks in the code? |
@matjaz I don't think a linear distribution of the amounts between min and max is what I would want as a user. When I tip someone I use those buttons as kind of shortcuts for smaller amounts. I don't think people would use a 1M sat button a lot, do you? 🤔 |
Using LNURL, When you tip someone you don't use LNURL (no min&max). There is no point of having disabled buttons. What do you suggest, @reneaaron ? @pavanjoshi914 fixed formatting. |
Ahh, okay. I wasn't considering this screen. Can you share the use case (and app) where you would think this would improve the flow for the user? The problem could be here that you won't be able to withdraw the full amount for most of the services. (they keep a little reserve to protect themselves from fee draining attacks) I think there are basically 2 use cases where those buttons are in use currently:
Every lightning address is a LNURL 🤔 (e.g. also your lightning address has min and max values defined) |
https://lntictactoe.com & https://www.lnflip.com enables balance withdrawal. Let's say user has a balance of 2500 sats, most of the buttons are disabled. For 150000 sats button values are too low. So for tag
|
Any feedback on this? |
Describe the changes you have made in this PR
Sats buttons 4 linear values from min to max, with nice rounding & formating. min & max values are unchanged.
Type of change
feat
: New feature (non-breaking change which adds functionality)Checklist