feat: Disable 'Create Invoice' button until an amount is entered #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes : getAlby#2802 The button is now disabled until the user enters a value in the 'Amount' field. This ensures that the user cannot create an invoice without specifying the amount first. This change helps to prevent invalid or incomplete invoice creation.
pavanjoshi914
requested changes
Oct 30, 2023
AdarshRawat1
force-pushed
the
dev-fix-Invoice-button
branch
from
f66ff1e
to
c935d8f
Compare
|
So we make 0-amount invoices unusable for all connectors that support that currently for the sake of disabling a button? I like the approach suggested here with the 0-amount invoice being shown by default on the receive screen (if there is no lightning address and the connector supports it) but until we have that I would prefer to keep this feature in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
The button is now disabled until the user enters a value in the 'Amount' field. This ensures that the user cannot create an invoice without specifying the amount first.
This change helps to prevent invalid or incomplete invoice creation.
Link this PR to an issue [optional]
Fixes #2802
Type of change
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Current - ( Button is active by default )
2023-10-29.14-13-40.mp4
After PR -( Button is disabled by default and enabled when user enters a value )
2023-10-29.14-07-53.mp4
Checklist