-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add screen reader labels for better accessibility #2960
Open
Rithvik-padma
wants to merge
12
commits into
getAlby:master
Choose a base branch
from
Rithvik-padma:#2573
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible with enter key
@rolnz Please review this PR. |
I have added some translation keys for some component screen reader labelling. I guess there is no need to run any script for newly added keys. If it is not the case please give some feedback for further translations changes. |
With all the changes since last year this is not mergeable now? @reneaaron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Adding screen reader labels to elements wherever necessary for better accessibility.
For both the menus (user and account menus) as the
Menu
component is being used tab keys cannot be used to traverse menu items so instead I have added a screen reader message at the beginning of menu so that the user is notified that he can only use the arrow keys to access menu items.Link this PR to an issue [optional]
Fixes #2573
Type of change
fix
: Bug fix (non-breaking change which fixes an issue)feat
: New feature (non-breaking change which adds functionality)How has this been tested?
Tested manually using a screen reader.
Checklist