Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return preimage for intraledger payments in galoy connector #2997

Conversation

openoms
Copy link
Contributor

@openoms openoms commented Jan 18, 2024

Using the returned preImage when the payment is settled intraLedger.

Maintaining the compatibility with the bitcoin Jungle wallet which still doesn't return the preimage for intraledger payments.

Fixes #2946

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshot from 2024-01-18 09-10-06
Screenshot from 2024-01-18 09-26-59

Tested manually in Firefox / LibreWolf.

Checklist

  • Self-review of changed code
  • Manual testing

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 💯

tACK

@reneaaron reneaaron merged commit 409f52a into getAlby:master Jan 24, 2024
6 of 7 checks passed
@openoms openoms deleted the fix/-return-preimage-for-all-blink-transactions branch January 24, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Galoy doesn't return preimage with WebLN
2 participants