Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react-i18next config #3010

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: update react-i18next config #3010

merged 2 commits into from
Feb 8, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

A clear and concise description of what you want to happen

Link this PR to an issue [optional]

Fixes #ISSUE-NUMBER

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • feat!: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • docs: Documentation update

Screenshots of the changes [optional]

Add screenshots to make your changes easier to understand. You can also add a video here.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

Copy link

socket-security bot commented Feb 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/i18next-browser-languagedetector@7.2.0 None +1 116 kB adrai
npm/i18next@23.8.2 None +1 879 kB adrai
npm/react-i18next@14.0.1 Transitive: environment +7 1.6 MB adrai

🚮 Removed packages: npm/i18next-browser-languagedetector@7.1.0, npm/i18next@22.5.1, npm/react-i18next@12.3.1

View full report↗︎

@pavanjoshi914 pavanjoshi914 changed the title feat: update dependency feat: update react-i18next config Feb 1, 2024
@@ -92,6 +92,7 @@ export default function PasswordForm<
<TextField
autoFocus={autoFocus}
id="password"
// @ts-ignore/currently ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reneaaron i was able to correct other breaking changes but this one, not yet. it always throw type safe errors. any idea why this happening?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't explain it either, must be caused by the keyPrefix being passed to the component. 🤷‍♂️

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@@ -92,6 +92,7 @@ export default function PasswordForm<
<TextField
autoFocus={autoFocus}
id="password"
// @ts-ignore/currently ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't explain it either, must be caused by the keyPrefix being passed to the component. 🤷‍♂️

@reneaaron reneaaron merged commit 9eb1bc3 into master Feb 8, 2024
6 of 7 checks passed
@reneaaron reneaaron deleted the i18next-dependency branch February 8, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants