Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper error handling for lnurl withdraw #3062

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

proper error handling for lnurl withdraw

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

image

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914 pavanjoshi914 changed the title fix: proper error handling fix: proper error handling for lnurl withdraw Feb 28, 2024
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron reneaaron enabled auto-merge (squash) February 29, 2024 10:42
@pavanjoshi914
Copy link
Contributor Author

fixed tests accordingly merging it

@pavanjoshi914 pavanjoshi914 merged commit 8c59f85 into master Feb 29, 2024
6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the withdraw-error-handling branch February 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants