feat: unify encrypt decrypt for nip04 and nip44 #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
tACK
@pavanjoshi914 Something seems to be not working with the migrations:
Steps to reproduce:
- Install old version, add permissions for nip 04 encrypt / decrypt
- Upgrade to new version
- Old permissions are not migrated it seems
|
@reneaaron it's working for me! i checked out master |
|
Tested again with a clean install, now it worked. Sorry 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
combine encrypt decrypt for nip04 and nip44
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)Checklist