Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet settings revamp #3133

Merged
merged 12 commits into from
May 10, 2024
Merged

feat: wallet settings revamp #3133

merged 12 commits into from
May 10, 2024

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Apr 25, 2024 •
edited
Loading

Describe the changes you have made in this PR

Revamp wallet settings

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@reneaaron reneaaron added the next-release To be included in the next release label Apr 29, 2024
@pavanjoshi914 pavanjoshi914 marked this pull request as ready for review May 1, 2024 12:16
@pavanjoshi914
Copy link
Contributor Author

@reneaaron if you are ok with it we shall do changes to nostr screen in separate pr. this is already getting bigger,

stackingsaunter
stackingsaunter requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@stackingsaunter stackingsaunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change "View recovery phrase" to capital — "View Recovery Phrase"?

Otherwise — tACK!

@pavanjoshi914
Copy link
Contributor Author

tAck

@pavanjoshi914 pavanjoshi914 merged commit 8cf20b9 into master May 10, 2024
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the revamp-wallet-settings branch May 10, 2024 09:15
@pavanjoshi914 pavanjoshi914 mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackingsaunter stackingsaunter stackingsaunter requested changes

@reneaaron reneaaron Awaiting requested review from reneaaron

Assignees
No one assigned
Labels
next-release To be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavanjoshi914 @stackingsaunter @reneaaron