Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dark mode text color #3190

Merged
merged 2 commits into from
Jul 19, 2024
Merged

chore: fix dark mode text color #3190

merged 2 commits into from
Jul 19, 2024

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

Fixes unused classes

Type of change

(Remove other not matching type)

  • chore

How has this been tested?

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914
Copy link
Contributor

from where those colors are referenced?

@im-adithya
Copy link
Member Author

Those are used in PopIcons (see classes passed to Arrow Up and Down icons)

@reneaaron
Copy link
Contributor

@im-adithya In the PR description you mention "Fixes unused classes", however it seems you just adjusted the colors. Also the new colors do not seem to match the figma designs?

image

@im-adithya
Copy link
Member Author

I actually meant dark:color-green-400 dark:color-orange-400 which don't mean anything and are unused. I took the dark classes from above as I didn't find emerald and amber colors for dark mode (see popicon colors in dark mode here and here) as we would want to match the amount color to the arrow inside the icon

@im-adithya im-adithya merged commit 764c8af into master Jul 19, 2024
6 checks passed
@im-adithya im-adithya deleted the task-dark-classes branch July 19, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants