Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Refactor: API cleanup #338

Merged
merged 20 commits into from
May 29, 2024
Merged

Refactor: API cleanup #338

merged 20 commits into from
May 29, 2024

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented May 26, 2024

Fixes getAlby/hub#101
Fixes getAlby/hub#102
Fixes getAlby/hub#111

  • Move LSP code out of API to new LSP service
  • Move backup to new Backup service
  • Fix wails router not supporting new channel endpoint
  • Fix LSPS1 not calculating refund address
  • Move config into separate package
  • Move lnclient files into packages under lnclient, each in their own package
  • Move http files into own package
  • Make info endpoint dumber, remove unused code
  • Move old models files

To move to a new issue:

Go:

  • move nip47 notifier into nip47 package
  • move nip47 handler methods into nip47 package
  • move wails code into wails package
  • move service code into own package
  • move tests out of main package
  • move main files into separate commands rather than using build tags
  • Review how LSP and backup services are accessed by API
  • Improve DB queries - join apps and permissions together
  • Remove duplication publishing error responses in handlers
  • Reduce duplication in multi_payment vs single payment methods
  • Simplify Wails request router
  • Replace session auth with JWT auth, remove CSRF

@rolznz rolznz marked this pull request as ready for review May 29, 2024 16:37
@rolznz rolznz merged commit 073d669 into master May 29, 2024
3 checks passed
@rolznz rolznz deleted the refactor/api branch May 29, 2024 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant