This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Store decrypted request method and content data #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows use to create an event log in the future and list the actual requests per app connection
It should not fail and if it fails it does not matter much I guess
rolznz
reviewed
May 31, 2024
| @@ -541,6 +541,10 @@ func (svc *Service) HandleEvent(ctx context.Context, sub *nostr.Subscription, ev | |||
| return | |||
| } | |||
|
|
|||
| requestEvent.Method = nip47Request.Method | |||
| requestEvent.ContentData = payload | |||
There was a problem hiding this comment.
should the ContentData be nip47Request.params?
{
"method": "pay_invoice",
"params": {
"invoice": "lnbc50n1...", // bolt11 invoice
"amount": 123, // invoice amount in msats, optional
}
}
And should we call it params to be consistent with the spec?
There was a problem hiding this comment.
do you think that's better?
then I have to JSON dump the params here.
There was a problem hiding this comment.
True. Maybe the way you did it is better.
There was a problem hiding this comment.
Do we still need to store the Content then? or we can remove this along with the content in the response event?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows use to create an event log in the future and list the actual requests per app connection