-
Notifications
You must be signed in to change notification settings - Fork 3
Add embedded Go pprof and DataDog profilers #366
Conversation
@bumi in the original PR, you have removed all the env configuration variables except |
@rdmitr do you remember the linter errors you got? we merged some linter changes but it should have only affected the frontend code, not the go code. |
@rdmitr makes sense. thanks |
Not really β I think some of the commit names were not formatted as expected by husky, and then it screwed up the merge and conflict resolution process in my IDE. I decided not to waste time trying to figure it out. But the husky rules certainly apply to the whole repo β I was quite surprised on Saturday when my commits suddenly started failing π |
@rdmitr do you understand what this part is caused by? Can we conclude that LDK consumes about 4X as much resources as our NWC code and our main two things that cause high CPU usage are Nostr event handling and DB access? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK for pprof.
We still need to deploy a datadog agent and enable profiling on some of our running hub instances.
Co-authored-by: Roman Dmitrienko <roman@dmitrienko.com> Co-authored-by: Roland Bewick <roland.bewick@gmail.com>
As far as I understand, that's goroutine management code
It looks like the profile was collected over a fairly short amount of time, so it's hard to say for sure. But yes, I would expect LDK code to be quite resource intensive |
This PR replaces #320 β I got linter errors when trying to merge and commit, so I figured it was easier to ditch it and create a new one π