This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
chore: merge app connection flows #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
commented
Jun 3, 2024
|
I did not look at the code but keep in mind that the Store-App Screen at least needs to contain some app specific instructions. |
rolznz
reviewed
Jun 6, 2024
rolznz
reviewed
Jun 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges the app connection flow for normal and app store apps. Fixes getAlby/hub#85
Screenshots
New App Screen
/apps/newApp Created Screen
/apps/createdNew Store-App Screen
/apps/new?app=appIdStore-App Created Screen
/apps/created?app=appId