This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
chore: return request_methods even without a permission #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
commented
Jun 13, 2024
rolznz
reviewed
Jun 13, 2024
@im-adithya did you post this in the wrong PR? |
|
Ah damn! I was wondering I typed it but couldn't find in the actual PR 🤦 |
|
@im-adithya can you update this PR? |
|
Done! |
rolznz
approved these changes
Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getAlby/hub#188 by only returning request_methods if there's no
get_infopermissionScreenshot
(First result with empty fields is without
get_infopermission and the second is with permission)