Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edwards cruve CompressedPublicKey #299

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

markya0616
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

Checklist

  • Fork the repository and create your new branch from master.
  • Please mention the name of community in Pull Request title.
  • Git Commit Messages
    • Use the present tense (Also in Pull Request title): "Add feature" not "Added feature"
    • Use the imperative mood (Also in Pull Request title): "Move cursor to..." not "Moves cursor to..."
    • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

cychuang0924
cychuang0924 previously approved these changes Nov 28, 2024
@@ -56,10 +57,18 @@ func (ed *ed25519) Slip10SeedList() []byte {

func (ed *ed25519) CompressedPublicKey(secret *big.Int, method string) []byte {
if method == BIP32ED25519 {
x, y := edwards.Edwards().ScalarBaseMult(secret.Bytes()[:32])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIP32ED25519 的原本是 bip32
幫我換成 BIP32ED25519 謝謝

@markya0616 markya0616 force-pushed the addSelfEd25519AndMethod-2 branch from 90f81ec to 526bdd9 Compare November 28, 2024 06:05
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (c70f57c) to head (526bdd9).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
crypto/elliptic/p256.go 20.00% 4 Missing ⚠️
crypto/elliptic/secp256k1.go 20.00% 4 Missing ⚠️
crypto/elliptic/ed25519.go 85.71% 2 Missing ⚠️
crypto/elliptic/elliptic_curve.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   75.92%   75.95%   +0.03%     
==========================================
  Files         152      152              
  Lines       11532    11530       -2     
==========================================
+ Hits         8756     8758       +2     
+ Misses       2016     2012       -4     
  Partials      760      760              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markya0616 markya0616 merged commit a5674a1 into master Nov 28, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants