[wip]: add contract package #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for qubic-js-sdk-example failed.
|
alanchchen
force-pushed
the
feature/add-contracts
branch
from
df857b0 to
a8c4cc7
Compare
alanchchen
force-pushed
the
feature/add-contracts
branch
from
a8c4cc7 to
2e0478f
Compare
alanchchen
force-pushed
the
feature/add-contracts
branch
from
2e0478f to
cbfcb2b
Compare
tn606024
reviewed
Jun 28, 2022
| import '@openzeppelin/contracts-upgradeable/utils/cryptography/draft-EIP712Upgradeable.sol'; | ||
| import '@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol'; | ||
|
|
||
| contract ForwarderUpgradeable is Initializable, OwnableUpgradeable, EIP712Upgradeable { |
There was a problem hiding this comment.
要繼承UUPSUpgradeable還有function要有_authorizeUpgrade才能做升級
| * variables without shifting down storage in the inheritance chain. | ||
| * See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps | ||
| */ | ||
| uint256[48] private __gap; |
|
|
||
| bytes memory data = abi.encode(META_TRANSACTION_TYPEHASH, authorizer, nonces[authorizer], keccak256(callData)); | ||
|
|
||
| require(EIP712.recover(DOMAIN_SEPARATOR, v, r, s, data) == authorizer, 'NativeMetaTransaction: invalid signature'); |
There was a problem hiding this comment.
我覺得這裡要擋掉recover回來的address是0x0000000000000000000000000000000000000000, 因為authorizer如果是0x0000000000000000000000000000000000000000, 不合法的signature是也會過的
|
|
||
| bytes memory data = abi.encode(CANCEL_META_TRANSACTION_TYPEHASH, authorizer, nonce); | ||
|
|
||
| require(EIP712.recover(DOMAIN_SEPARATOR, v, r, s, data) == authorizer, 'NativeMetaTransaction: invalid signature'); |
| validBefore | ||
| ); | ||
|
|
||
| require(EIP712.recover(DOMAIN_SEPARATOR, v, r, s, data) == authorizer, 'NativeMetaTransaction: invalid signature'); |
| ) internal view { | ||
| _requireValidFuntionCall(callData); | ||
|
|
||
| if (relayer != address(0)) { |
| deadline | ||
| ); | ||
|
|
||
| require(EIP712.recover(DOMAIN_SEPARATOR, v, r, s, data) == authorizer, 'NativeMetaTransaction: invalid signature'); |
| nonces[authorizer] = nonces[authorizer].add(1); | ||
|
|
||
| // Append authorizer at the end to extract it from calling context | ||
| (bool success, bytes memory returnData) = address(this).call(abi.encodePacked(callData, authorizer)); |
There was a problem hiding this comment.
value應該要帶進去
(bool success, bytes memory returnData) = address(this).call{value: msg.value}(abi.encodePacked(callData, authorizer));
| _requireValidAuthorization(relayer, authorizer, nonce, callData, deadline, v, r, s); | ||
|
|
||
| // Append userAddress at the end to extract it from calling context | ||
| (bool success, bytes memory returnData) = address(this).call(abi.encodePacked(callData, authorizer)); |
| _requireValidAuthorization(relayer, authorizer, nonce, callData, validAfter, validBefore, v, r, s); | ||
|
|
||
| // Append userAddress at the end to extract it from calling context | ||
| (bool success, bytes memory returnData) = address(this).call(abi.encodePacked(callData, authorizer)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.