Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent statements in docs #302

Closed
tgelu opened this issue Jan 27, 2023 · 0 comments · Fixed by #310
Closed

Inconsistent statements in docs #302

tgelu opened this issue Jan 27, 2023 · 0 comments · Fixed by #310

Comments

@tgelu
Copy link

tgelu commented Jan 27, 2023

On https://getbem.com/naming/ we read:

Block names may consist of Latin letters, digits, and dashes.

But the first and most prominent example in the frontpage contains:

.opinions_box { // <-- contradicts the previous statement
    margin: 0 0 8px 0;
    text-align: center;

    &__view-more {
        text-decoration: underline;
    }

    &__text-input {
        border: 1px solid #ccc;
    }

    &--is-inactive {
        color: gray;
    }
}

If a block name may contain letters, digits and dashes it may NOT contain anything else, including an underscore.

I don't know where a change should be made, but I think it should be corrected :)

Cheers

floatdrop pushed a commit that referenced this issue Nov 8, 2023
Made a decision about how names should look.
Block and elements have no casing guidance so the convention becomes
more subjective.

Fixes #302
I feel like I should mention that I read through
#94 but there wasn't a
strong consensus either way

Apologies for the double PR, I misspelled the branch name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant