Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DittoSyncStatusHelper tool #162

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add DittoSyncStatusHelper tool #162

wants to merge 14 commits into from

Conversation

bplattenburg
Copy link
Member

@bplattenburg bplattenburg commented Nov 16, 2024

Closes TOOLS-304

I posted this now to start getting feedback, but I want to call out that this is the barebones tool and does not yet include:

  • Any UI
  • Sample usage
  • A section in the All Tools App
  • A Combine Publisher for the status in addition to the closure

@bplattenburg bplattenburg requested a review from a team as a code owner November 16, 2024 20:58
@bplattenburg bplattenburg marked this pull request as draft November 27, 2024 15:40
@@ -59,6 +59,22 @@ public class DittoSubscriptionsStatusHelper {
}
}

/**
Creates a new` DittoSyncStatusHelper` for all of the currently active subscriptions on this Ditto instance *at the time this is created*. It will not update if those subscriptions change

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Looks like there's a space after the first backtick '`' before DittoSyncStatusHelper

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

linear bot commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants