Document fields and fix lifetime issue #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| capacity, | ||
| vtable: <ptr::NonNull<BytesVt> as From<&'static _>>::from(&ARC_BYTES_VT).cast(), | ||
| marker: core::marker::PhantomData, | ||
| } | ||
| } | ||
| } | ||
| #[cfg(feature = "alloc")] | ||
| impl<'a, T: Sized + AsRef<[u8]> + Send + Sync + 'a> From<Arc<T>> for Bytes<'a> { | ||
| impl<'a, T: Sized + AsRef<[u8]> + Send + Sync + 'static> From<Arc<T>> for Bytes<'static> { |
There was a problem hiding this comment.
Suggested change
| impl<'a, T: Sized + AsRef<[u8]> + Send + Sync + 'static> From<Arc<T>> for Bytes<'static> { | |
| impl<T: Sized + AsRef<[u8]> + Send + Sync + 'static> From<Arc<T>> for Bytes<'static> { |
Btw, can you expand on the example of Arc<&'not_static [u8]> -> Bytes<'a> being unsound?
There was a problem hiding this comment.
Since this constructor sets a release function in the vtable, Bytes is free to assume it fully owns the data (allowing upgrades without copies), even though an Arc<&'non_static [u8]> doesn't actually own said data.
danielhenrymantilla
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bytesfrom_raw_partsconstructor.Bytesis constructed fromArc<&'a [u8]>(for example)