New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bytes serde support + add tests #238

Merged

danielhenrymantilla merged 3 commits into master from ff/fix-bytes-serde

Sep 4, 2024

Contributor

S4H commented Sep 4, 2024

Relaxes the serde version required to match the monorepo
Adds tests using serde_test for Bytes ser/de operations

s4h added 3 commits

September 4, 2024 10:05


          Fix Bytes serde support + add test

6e40dad


          Don't blow up when a deserializer returns a Seq

3e7fbb4


          Cover byte/bytebuf cases

S4H requested a review from danielhenrymantilla

September 4, 2024 09:49

danielhenrymantilla approved these changes

View reviewed changes

src/bytes.rs

+              #[cfg(feature = "serde")]
+              impl<'de> serde::de::Visitor<'de> for BytesVisitor {
+                  type Value = Bytes<'de>;

Collaborator

danielhenrymantilla Sep 4, 2024

Very nice

danielhenrymantilla merged commit aaa4014 into master

206 checks passed

danielhenrymantilla deleted the ff/fix-bytes-serde branch

September 4, 2024 12:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet