Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatic skip scenario #210

Merged

Conversation

PiotrNestor
Copy link
Contributor

According to the discussion in: getgauge/gauge#2502

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@PiotrNestor
Copy link
Contributor Author

@sriv
Go version 1.22 update on Linux issues ...

@PiotrNestor
Copy link
Contributor Author

@sriv
Any progress on this PR?

@sriv
Copy link
Member

sriv commented May 22, 2024

i will need to make some time to debug this.

@PiotrNestor
Copy link
Contributor Author

@sriv
This PR is updated with the latest master updates
The Linux build have problem with --> go: download go1.22 for linux/amd64: toolchain not available

@sriv
Copy link
Member

sriv commented May 23, 2024

@PiotrNestor - I made some changes to the GH actions workflow, could you please rebase this PR?

@PiotrNestor
Copy link
Contributor Author

@sriv
I've missed the rebase request. Now it's done

@sriv
Copy link
Member

sriv commented Jun 5, 2024

looks like I missed the setup-go changes for lsp tests. Would you be able to add

      - name: Setup go
      - uses: actions/setup-go@v5
        with:
          go-version: '1.22'
          cache: false

to the LSP tests flow @PiotrNestor ?

@sriv sriv enabled auto-merge (squash) June 5, 2024 14:03
@PiotrNestor
Copy link
Contributor Author

@sriv
Can this PR be merged now?

@sriv sriv disabled auto-merge June 7, 2024 07:04
@sriv sriv merged commit 817fdaf into getgauge:master Jun 7, 2024
6 checks passed
@sriv
Copy link
Member

sriv commented Jun 7, 2024

the DCO check was hung. So I force-merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants