Fix tests on Node 20.8.0+ #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
node-2080
branch
from
775f3e4
to
ec77350
Compare
Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
chadlwilson
force-pushed
the
node-2080
branch
from
ec77350
to
d2dee4d
Compare
chadlwilson
added
ReleaseCandidate
|
@chadlwilson Thank you for contributing to gauge-js. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
chadlwilson
force-pushed
the
node-2080
branch
from
d2dee4d
to
9788617
Compare
Switch to mock-tmp which avoids attempting to mock the node `fs` package, which is increasingly difficult, and instead just creates a dummy file structure in temp directories. Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
chadlwilson
force-pushed
the
node-2080
branch
from
9788617
to
1287473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mock-fs performs deep mocking on node/fs internals which seems to be rather brittle. And it's broken on Node 20.8.0+ right now.
Based on the changelog at https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-09-28-version-2080-current-ruyadorno , I am guessing it's some of the changes such as nodejs/node#49593 or nodejs/node#49691
Replaced here with
mock-tmp, a simple library that keeps roughly the same API asmock-fsfor ease of migration, but uses real files on the filesystem.