Update Python unittests and apply Python standard #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sschulz92 <bastie92_spam@gmx.de>
sschulz92
force-pushed
the
UPDATE_PY_TESTS
branch
from
8792910
to
4445002
Compare
|
Automated tests are run against newest Python point release and the oldest supported Python point release, so 3.9 and 3.12 at time of writing. Logic being that the versions in between should also work. gauge-python/.github/workflows/tests.yml Lines 15 to 18 in f0493d2 But that doesn't mean that all possible features are supported, as you are aware of from #324 and #233 since the library is dependent on third party dependencies and is not tested with all possible Python language features that might need to be parsed :-/ There is https://github.com/getgauge/gauge-python/blob/master/tox.ini however I don't think this is used anywhere on the current build since being moved to GHA. |
chadlwilson
reviewed
Sep 27, 2024
chadlwilson
approved these changes
Oct 1, 2024
sschulz92
added a commit
to sschulz92/gauge-python
that referenced
this pull request
Oct 1, 2024
Signed-off-by: sschulz92 <bastie92_spam@gmx.de> Co-authored-by: Chad Wilson <chadw@thoughtworks.com> Signed-off-by: sschulz92 <bastie92_spam@gmx.de>
sschulz92
added a commit
to sschulz92/gauge-python
that referenced
this pull request
Oct 1, 2024
Signed-off-by: sschulz92 <bastie92_spam@gmx.de> Co-authored-by: Chad Wilson <chadw@thoughtworks.com> Signed-off-by: sschulz92 <bastie92_spam@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating into "Add support to skip scenarios on runtime" I stumbled about several smaller code-smells reported by Pylance. Boy-scout-rule-wise I would like to contribute them as part of this PR.
Out of curiosity: Is there a guideline which Python versions are supported? Could not find relevant information in the Gauge docs.