Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate step implementations for steps with no duplicates #55

Closed
sswaroopgupta opened this issue Jan 22, 2018 · 3 comments
Closed

Duplicate step implementations for steps with no duplicates #55

sswaroopgupta opened this issue Jan 22, 2018 · 3 comments
Labels
bug

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jan 22, 2018 •
edited
Loading

Expected behavior
Should get duplicate step implementation only if steps have multiple implementations.

Actual behavior
Switching between spec file and ruby file, we get duplicate step implementation on all steps defined in the file.

Steps to replicate

  • Create a new gauge-ruby project
  • Switch between spec and .rb file

Note: The duplicate step implementation highlight on all steps.

Version

Gauge version: 0.9.8.nightly-2018-01-19
Commit Hash: 0c66ca4

Plugins
-------
ruby (0.4.3.nightly-2018-01-18)

Bug on story getgauge/gauge-vscode#85
@sswaroopgupta sswaroopgupta mentioned this issue Jan 23, 2018
Closed
sriv added a commit that referenced this issue Feb 6, 2018
@sriv
check path explicitly, instead of string compare, #55
90e19ab
@sriv
Copy link
Member

sriv commented Feb 6, 2018

Fix should be available in nightly >= 02/06/2018

@sswaroopgupta
Copy link
Contributor Author

This fix seems to have broken Goto definition - getgauge/gauge-vscode#132

Note: Goto definition works with ruby nightly gauge-ruby-0.4.3.nightly-2018-01-18-windows.x86_64.zip

@sswaroopgupta sswaroopgupta reopened this Feb 7, 2018
@sswaroopgupta
Copy link
Contributor Author

Still replicable in

Gauge version: 0.9.8.nightly-2018-02-02
Commit Hash: bff4f46

Plugins
-------
ruby (0.4.3.nightly-2018-02-07)

@zabil zabil added ready and removed ready for QA labels Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zabil @sriv @sswaroopgupta @BugDiver