Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] IDE feature should work when project names are similar #96

Closed
sswaroopgupta opened this issue Jan 16, 2018 · 7 comments
Closed
Assignees
Labels

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jan 16, 2018

Expected behavior
IDE Features should work irrespective of project names

Actual behavior
When one project name is a subset of the other. Example something and something-else. The following issues occur

  • Find usages display wrong details

findusages

* Code lens appears twice

codelens

  • Autocomplete is not limited to elements in workspace

  • Duplicate step implementation is displayed for steps across projects in workspace

Steps to replicate

  • Create project one. gauge init js
  • Create another project onemore gauge init js
  • Add both to one workspace
  • Observe the above issues

Version

Gauge version: 0.9.8.nightly-2018-01-15
Commit Hash: 15c9822

Plugins
-------
js (2.1.1.nightly-2018-01-15)
@Apoorva-GA
Copy link
Contributor

Raised an issue in vscode.

@Apoorva-GA
Copy link
Contributor

Fix should be available in gauge and vscode nightly >= 19/01/18

@sswaroopgupta
Copy link
Contributor Author

Seems like VSCode is giving a fix for the raised issue in vscode. We should take a re-look after their fix.

@Apoorva-GA
Copy link
Contributor

VSCode has released a fix for this issue.
Please test with insider Version 1.20.0-insider.(60440c72461e96893766bce73d7bdf1f5136a19f) release on 2018-01-23.

@sswaroopgupta
Copy link
Contributor Author

Code Lens appear only once. With Find Usages statistics are displayed correctly.
However

  • Clicking on the usage statistics does not list the usages.

@sswaroopgupta
Copy link
Contributor Author

Working in VSCode -

Version 1.20.0-insider
Commit 757ff83f0dece1ecf43d3a92e91fe467de1cc9dc
Date 2018-01-29T05:13:39.772Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

@ghost ghost removed the ready for QA label Jan 29, 2018
@sswaroopgupta
Copy link
Contributor Author

Issue
Ruby projects are not working as expected in this Insider version - #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants