Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix params type for step ref request. #1858

Merged
merged 9 commits into from
Apr 1, 2021
Merged

Fix params type for step ref request. #1858

merged 9 commits into from
Apr 1, 2021

Conversation

BugDiver
Copy link
Member

Fix #1857

Signed-off-by: BugDiver <vinaysh@thoughtworks.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2021

Benchmark Results

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 180% 376804 0:18.33 0
c532320 182% 355644 0:20.04 0
c93f7af 179% 558492 0:33.83 0
0921ec1 180% 563572 0:29.78 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 181% 318024 0:17.65 0
c532320 181% 338348 0:18.11 0
c93f7af 147% 296200 0:30.25 0
0921ec1 180% 296660 0:27.61 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 178% 394976 0:20.54 0
c532320 178% 374068 0:20.26 0
c93f7af 166% 639544 0:30.80 0
0921ec1 182% 574344 0:42.51 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 179% 388428 0:21.85 0
c532320 177% 349640 0:21.11 0
c93f7af 166% 619168 0:33.39 0
0921ec1 175% 557240 0:43.04 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 185% 316576 0:20.36 0
c532320 188% 316540 0:20.17 0
c93f7af 182% 324672 0:20.33 0
0921ec1 181% 325640 0:20.03 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 183% 355184 0:23.08 0
c532320 183% 303728 0:22.61 0
c93f7af 153% 362648 0:37.51 0
0921ec1 161% 301948 0:27.06 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 179% 351068 0:13.29 0
c532320 170% 343216 0:14.42 0
c93f7af 163% 341344 0:15.11 0
0921ec1 176% 414552 0:13.43 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 184% 318832 0:21.98 0
c532320 184% 340820 0:20.92 0
c93f7af 158% 341744 0:31.93 0
0921ec1 150% 302156 0:30.51 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 181% 397856 0:13.15 0
c532320 174% 384524 0:13.73 0
c93f7af 174% 385536 0:14.13 0
0921ec1 172% 407336 0:16.52 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@zabil
Copy link
Member

zabil commented Jan 15, 2021

@BugDiver can you add some details about why this is a problem only for the typescript plugin while step references on other platforms seem to pass.

@gaugebot
Copy link

gaugebot bot commented Mar 31, 2021

@BugDiver Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
@zabil
Copy link
Member

zabil commented Mar 31, 2021

Added a bunch of commits that fixes lint issues from upgrade to a new version of golang-lint

Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Unable to start LSP on MacOS with ts plugin
2 participants