Execute before and after for each spec

[barnesjohnraymond]

This pull request aims to fix the issue described in #2270. The before and after actions should always be executed for each spec. Setting these values to false actually only makes sense for testing purposes.

Signed-off-by: John Barnes barnesjohnraymond@gmail.com

[barnesjohnraymond]

@zabil
Could you please have a look at this pull request and, if it looks ok for you, approve the workflows to be run?

[barnesjohnraymond]

@zabil @sriv @johnboyes
I cannot find out who else is a maintainer of this project but could someone of the maintainers please have a look at this pull request and approve the open workflows? Thank you!

[sriv]

@barnesjohnraymond - thanks for the ping and apologies for not getting back earlier.

I looked at the changeset, and I can see that you've removed some state checks. This code was written a while back as part of a7d368b and 716adb3.

Looking at the commit history, I feel that removing the state checks will break the table driven execution for the spec (note that for table driven execution, it is expected that the before/after are run once).

I am going to try and spend some time to understand #2270 better, let's discuss this further there. I'll keep this PR open for now.