Replacing deprecated hub with gh cli #2351
Conversation
.github/workflows/tests.yml
Outdated
| @@ -10,309 +10,25 @@ permissions: | |||
| contents: read | |||
|
|
|||
| jobs: | |||
| tests: | |||
There was a problem hiding this comment.
Are these commented out for testing if gh pr works?
There was a problem hiding this comment.
yeah just speeding the feedback loop.
There was a problem hiding this comment.
Just trying to fix the brew release after the merge today.
There was a problem hiding this comment.
While you're here, @zabil, why does the automatic rebase action failing on master and how can I fix it?
There was a problem hiding this comment.
I am not very sure. I don't recollect setting it up.
I think instead of an automatic rebase we should turn on merge queues https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request-with-a-merge-queue
There was a problem hiding this comment.
I agree. I don't thing we should be auto rebasing PRs ourselves. I have enabled the following which would force people to update their PRs before we can merge.
Happy for me to remove the auto rebase action?
haroon-sheikh
force-pushed
the
fix-brew-release
branch
from
1e08501
to
fba6b12
Compare
Signed-off-by: iddevops-bot <getgauge@outlook.com>
haroon-sheikh
force-pushed
the
fix-brew-release
branch
from
cbd1f90
to
b1ee50e
Compare
|
@haroon-sheikh Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Signed-off-by: Haroon Sheikh haroon.sheikh@outlook.com