-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds gauge_concepts_dir for defining concepts directory #2379
Conversation
httpUtils tests are currently failing on windows only due to changes in latest golang release 1.20.6. Possibly related to golang/go#61076 |
9950653
to
d49cd26
Compare
I guess we could temporarily lock at |
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
@chadlwilson I looked at pinning to 1.20.5 also but it was still failing. After reverting all of my changes and adding smaller bits I've found out its this test thats causing the panic Any ideas what could be going wrong? |
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@outlook.com> Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
@haroon-sheikh Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
I am just curious the use case of this? |
Hi @cemerick1, as described in the issue. By default, gauge scans for concepts within the full project. This allows us to have a completely separate directory for concepts including outside of the project. |
Thanks @haroon-sheikh for the quick response! Reason I ask is because we would like to limit or completely remove concept steps from appearing in our intellisense/code completion without losing the ability to use them as we are trying to keep it simple. Does this new feature grant us that ability? |
Yes I think so. If you set the gauge_concepts_dir property to some other directory other than specs/ then it shouldn't include them. |
Good deal! We will give this a whirl on Monday and I will report my findings! |
Actually just thinking about it in detail, it will still show up suggestions for code completions as they're just steps for use in specs. It might be worth trying it out anyways. Feel free to raise a separate issue if it doesn't work and we could explore options for you. |
Appears it didn't work. I have submitted a new issue here #2383 |
Fixes #2311
By default, gauge searches with both
<project root>
andgauge_specs_dir
for searching and validating the concepts.This change is adding a new
gauge_concepts_dir
property so that so we can limit the concepts validation to specific directories. If this isn't set, then current behaviour applies for backward compatibility.Documentation: getgauge/docs.gauge.org#338