Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show_modular not working any more on the pages field #1080

Closed
flaviocopes opened this issue Apr 21, 2017 · 3 comments
Closed

show_modular not working any more on the pages field #1080

flaviocopes opened this issue Apr 21, 2017 · 3 comments
Assignees
@rhukster
Labels
bug fixed

Comments

@flaviocopes
Copy link
Contributor

This commit removed it, in c48b664

Was this intended, or simply forgotten in the new implementation?
@rhukster
Copy link
Member

Ya missed it. Should still be an option.

@rhukster rhukster added the bug label Apr 21, 2017
@rhukster rhukster self-assigned this Apr 21, 2017
rhukster added a commit that referenced this issue Apr 22, 2017
@rhukster
Allow show_modular: true|false to work again in parents/pages field #…
7422d39 
…1080
@rhukster
Copy link
Member

Fixed with latest Grav and Admin develop branches

@rhukster rhukster added the fixed label Apr 22, 2017
@rhukster
Copy link
Member

BTW, show_all overrides this and shows every page.. so you need show_all=false and show_modular=false to actually hide modular pages.

ricardo118 added a commit to ricardo118/grav-aviary-plugin that referenced this issue Apr 26, 2017
@ricardo118
Updated Grav Admin to v1.4.2
0e8a624 
1. [](#new)
    * Added a new `Content Padding` option to tighten up UI padding space (default `true`)
1. [](#bugfix)
    * Added back `Admin::initTheme()` relying on Grav fix [#1069](getgrav/grav-plugin-admin#1069) as it conflicts ith Gantry5
    * Fix for missing scrollbar when in full-size editor for Firefox [#1077](getgrav/grav-plugin-admin#1077)
    * Fix for overlay of Add-Page button in full-size editor [#1077](getgrav/grav-plugin-admin#1077)
    * Better fix for session-based parent overriding root page parents [#1078](getgrav/grav-plugin-admin#1078)
    * Allow support for `Pages::getList()` with `show_modular` option [#1080](getgrav/grav-plugin-admin#1080)
    * Added `[tmp,user]` ignores for direct install of Grav [grav#1447](getgrav/grav#1447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhukster rhukster

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhukster @flaviocopes