-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding for expert view toggle buttons to low #1089
Comments
This is a bit tricky, because the tabs are actually rendered first, and have no clue abut the expert/normal and language dropdown which is coming from the content but is absolutely positioned. I'll have to think about this one. |
With the buttons and dropdown absolutely positioned, is there not a permanent risk of collision? They could be scaled hierarchically, where level 1 has two elements: One 80% width for Tabs and one 20% width for the Remainder. On level 2 Tabs are distributed equally through flex or just inline-blocks, and the Remainder allocates 10% width for the language-dropdown, and 45% width for each button. For the buttons within Remainder on level 2, overflow is hidden so that on smaller resolutions or when there is a conflict in width, as much as possible text is shown from each button - but they will not barge into the Tabs. |
Well my plan is to have a twig block position i can inject the selectors into. That way we can use flex box for the whole thing and things will always fit nicely. |
Ok, it's just not possible with the approach i had hoped to use as the tabs are generated by the blueprint and there's no way to extend them in there. I have a bit 'hackish' but effective solution that just sets the margin based on the width of that block via JavaScript. |
Depending on the chosen language, the padding in the
tabs-nav
for theadmin-topbar
is to low.Englisch
German
About 380 Pixel would fit for German but because this depends on the language, it would be better to calculate it dynamically.
The text was updated successfully, but these errors were encountered: