Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System configuration in Admin Panel #27

Closed
maxlysenko opened this issue Aug 7, 2015 · 4 comments
Closed

System configuration in Admin Panel #27

maxlysenko opened this issue Aug 7, 2015 · 4 comments

Comments

@maxlysenko
Copy link

  • If there is no system.yaml file in user/config folder admin panel saves changes into system/config/system.yaml instead of creating new user/config/system.yaml file. Maybe it's better to create new user configuration than overwrite initial system configuration?
  • When saving configuration, two keys (markdown and page) with value 1 are added into system.yaml file:
markdown: '1'
page: '1'

Next, each time you save configuration, values of 1 are added to these keys, so it becomes something like:

markdown:
  - '1'
  - '1'
  - '1'
  - '1'
  - '1'
page:
  - '1'
  - '1'
  - '1'
  - '1'
  - '1'

What is this intended for?

  • It would be useful to see which configuration file (system/config/system.yaml or user/config/system.yaml or user/localhost/config/system.yaml or other environment configuration) is in use and will be saved, or even add an option to select configuration file for editing.
@rhukster
Copy link
Member

rhukster commented Aug 7, 2015

You have multiple things here :) Really should be in separate issues next time:

  1. Yes, this should create a user/config/system.yaml if it does not exist.. that's currently missing

  2. Not sure what those two values are, or where they are coming from. Will track them down...

  3. We have a todo to add the ability of which config you are editing. Currently Grav will save in the most specific location. So user/localhost/config/system.yaml > user/config/system.yaml for example.

@rhukster
Copy link
Member

rhukster commented Aug 7, 2015

second issue has been broken out into it's own #34 issue

@rhukster
Copy link
Member

rhukster commented Aug 8, 2015

first issue is now resolved also. Admin will create /user/config/system.yaml and /user/config/site.yaml if they don't exist. This way any modifications will always be saved there.

@rhukster
Copy link
Member

Last part of this issue:

configuration grav2 2015-08-21 15-28-33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants