Add config.param_sep support for admin panel (this fixes #30, #36; see #39)
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sommerregen
force-pushed
the
bugfix/fix-spl-error
branch
from
9acde18 to
0165f53
Compare
This was referenced Aug 8, 2015
Sommerregen
changed the title
config.param_sep support for admin panel (this fixes #30, #36; see #39)
|
@w00fz you mind reviewing the JS portion of this? |
|
Looks good! // Djamil Legato // From iPhone //
|
|
Nice and I'm glad to help :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #30. Here the admin route was broken due to included
task:and a logout page and a theme template missing.UPDATE: It turned out that the route wasn't the problem, but actually a windows specific setting, namely
system.config_sep: "+", which was not correctly implemented in the admin theme templates..