Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapted to configurable paths #29

Closed
wants to merge 2 commits into from
Closed

adapted to configurable paths #29

wants to merge 2 commits into from

Conversation

makuhama
Copy link
Contributor

@makuhama makuhama commented Apr 6, 2021

@mahagr mahagr requested a review from rhukster April 9, 2021 08:49
@mahagr
Copy link
Member

mahagr commented Apr 9, 2021

@rhukster These changes are needed to make problems plugin to work with custom paths.

@mahagr
Copy link
Member

mahagr commented Apr 13, 2021

I'm starting to wonder if the plugin should use those at all... As at the point when the plugin runs, all of those paths may have been changed by the configuration.

@makuhama
Copy link
Contributor Author

I'm starting to wonder if the plugin should use those at all... As at the point when the plugin runs, all of those paths may have been changed by the configuration.

Actually that's a good point from my packager perspective. Nevertheless I would prefer to have this patch in the main branch. Sooner or later (probably after configurable paths have been documented) someone will install Grav manually and take advantage of configurable paths (as I did initially) and run into the problems plugin complaining about missing or non-writeable directories.

@mahagr
Copy link
Member

mahagr commented Apr 13, 2021

I just updated the plugin to support this better as well as went through the code.

@mahagr mahagr closed this Apr 13, 2021
@makuhama makuhama deleted the feature/configurable-paths branch April 13, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants