when grav fails, HTTP error should be returned instead of 200

[AddaxSoft]

When grav fails due for example to file access error, error HTTP 200 is currently returned.
This behavior confuses health check system to think everything is alright :)

Instead an HTTP 5xx error should be returned instead, so the health check systems can trigger

[rhukster]

Whenever there's an error, i'm seeing a 500 error returned as expected. Can you please provide an example of how to get an error with a 200 response?

[flaviocopes]

I added the enhancement label because I could reproduce the problem, but after a bit of research this is a PHP-level thing, when display_errors is enabled, and/or xdebug is enabled, parse errors trigger a 200, seems so it's able to correctly display the error message. Non-parse errors are always correctly handled.

So, not a Grav issue, but an environment setting. (see https://bugs.php.net/bug.php?id=50921)

After disabling errors:

[AddaxSoft]

OK, here is how to reproduce the problem:
when I change the owner of all folders to root, some dirs will lose the "write" permission automatically to www-data; hence Grav will complain about not being able to write to some folders.

Instead of displaying error 500, Grav displays a normal 200 with error page that some folders are not writable.

[flaviocopes]

Oh ok that's the Problems plugin output. It can be fixed by adding a http_response_code(500); here: https://github.com/getgrav/grav-plugin-problems/blob/develop/problems.php#L121

Can you check if this solves your problem?

[AddaxSoft]

@flaviocopes yes it works as expected now!
The web server returns a HTTP-500 error WITH the explanation of the error instead of the HTTP-200

The health checker now reports a problem with the server in this case :)

Thank you!