Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleared text field does not get saved #2890

Closed
clivebeckett opened this issue Apr 21, 2020 · 1 comment
Closed

Cleared text field does not get saved #2890

clivebeckett opened this issue Apr 21, 2020 · 1 comment
Assignees

Comments

@clivebeckett
Copy link

In the Admin Plugin v1.10-rc8, it is not possible to clear previously stored text via the interface.

Consider having text stored in a page’s markdown file’s body. Now when you clear this text in the Admin Plugin interface completely, this will be ignored when you hit the SAVE button. You can overwrite the text as long as there is any single character in the text field. But when you save with an empty text field, the previously stored text will still be there after the reload.

@rhukster rhukster assigned mahagr and rhukster and unassigned rhukster Apr 21, 2020
@mahagr mahagr transferred this issue from getgrav/grav-plugin-admin Apr 24, 2020
@mahagr mahagr changed the title [BUG | Admin v1.10.0-rc.8] Cleared text field does not get saved Cleared text field does not get saved Apr 24, 2020
@mahagr mahagr added the fixed label Apr 24, 2020
@clivebeckett
Copy link
Author

I finally tested it in Admin v1.10.0-rc.11 – and it works: you can save an empty text field again when it was previously filled.

Thanks a lot for fixing this so quickly! Should I close the issue? Or is that usually done by you?

@mahagr mahagr closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants