Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conflicts .md ! #995

Closed
ash0080 opened this issue Aug 21, 2016 · 8 comments
Closed

Naming conflicts .md ! #995

ash0080 opened this issue Aug 21, 2016 · 8 comments
Labels

Comments

@ash0080
Copy link
Contributor

ash0080 commented Aug 21, 2016

2016-08-21 10 56 48
As the attached img displayed,
In this case, system mistakenly believes 13.md is the page file, so require 13.html.twig as a template file, But does not actually exist!

Grav v1.1.3 - Admin v1.1.4

@rhukster
Copy link
Member

Yes I an see in the code how this could happen. It's never come up before that someone would name a folder 'something.md', but i'll look at sorting it.

@rhukster rhukster added the bug label Aug 21, 2016
@ash0080
Copy link
Contributor Author

ash0080 commented Aug 21, 2016

Yes, It's unusual. The folder names are abbreviation of US states. I use them to generate a sorted list of locations for a custom plugin of mine.

But I think strict distinguishing between folders and files suffixes makes the system robuster.

rhukster added a commit that referenced this issue Aug 21, 2016
@rhukster
Copy link
Member

Should be sorted with the above commit.

@ash0080
Copy link
Contributor Author

ash0080 commented Aug 25, 2016

@rhukster

I got an error message

"LogicException
The parent constructor was not called: the object is in an invalid state"

@rhukster
Copy link
Member

i'm not able to replicate this. What version of PHP? Are you sure you updated the pages.php file correctly?

@ash0080
Copy link
Contributor Author

ash0080 commented Aug 25, 2016

I found the problem,
$pages_found->count() not exsit
PHP7

@rhukster
Copy link
Member

Oh I fixed that straight away, in the next commit. de1d824

@ash0080
Copy link
Contributor Author

ash0080 commented Aug 25, 2016

It works now, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants