Fix Page Collections problem with @page.modular

[haagvivi]

Loading the page children before call modular on the Collection.

In order to view the complete example issue you can refer to https://getgrav.org/forum#!/general:cant-get-modular-collectio

[rhukster]

Thanks I'll look at this soon and review.

[flaviocopes]

I tested and replicated the problem, the PR is fixing it.

[mahagr]

There are two kinds of children: modular and non-modular. After the fix both will be returned, which is not correct.

[mahagr]

Try creating a modular page with sub-menu in it. You really need to add a test for modular item before adding the child pages.

[flaviocopes]

I tried adding a non-modular child, it's not picked up, as it's calling $results->modular();. Not sure if I "got" the problem you notice

[mahagr]

You were right, I was blind.

[haagvivi]

Yes, the modular function juste keep the modular pages.