Improve detection of home path. Also allow ~/.grav on Windows, drop ConsoleTrait::isWindows() method, used just for that.

[flaviocopes]

Refs

• Make use of user config multiplatform #1203
• Windows detection is broken #1202

[c33s]

i will test it on my windows machine asap.

[c33s]

why not put this (69-73 in this file) and line 116-119 from gmp into the console trait?

public function loadLocalConfig($cli=false) 
{
    $home_folder = getenv('HOME') ?: getenv('HOMEDRIVE') . getenv('HOMEPATH');
    $local_config_file = $home_folder . '/.grav/config';
    if (file_exists($local_config_file)) {
        $this->local_config = Yaml::parse($local_config_file);
        if ($cli) {
            $this->output->writeln('Read local config from <cyan>' . $local_config_file . '</cyan>');
        }
    }
}

calling it with $this->loadLocalConfig(true) or $this->loadLocalConfig(false)

or change the if ($cli) to:

if ($this->output && get_class($this->output)=='OutputInterface') 

and remove the $cli parameter from loadLocalConfig

[flaviocopes]

Good idea, I've extracted the method to ConsoleTrait as you suggested, with the change that it returns the local file path if found.