Add more controls over HTML5 video attributes (autoplay, poster, loop, controls) #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
not work for current version |
|
@ash0080 The change was merged in the v1.3.0-rc.1. The current version 1.2.4 don't have this feature. |
|
@pfcloutier-druide see, thank you ;) |
rhukster
pushed a commit
that referenced
this pull request
Nov 28, 2017
Adds support for `autoplay`, `controls`, `loop`, and `preload` attributes, with rudimentary validation for preload. Those for `autoplay`, `controls`, and `loop` are copied directly from pfcloutier-druide/aaa3f82 See also #1442.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented some methods to support basic features of HTML5 videos. I saw this pull request #1092 after. I have then adjusted to fit the requirement mentioned.
Example in Markdown :
Example in twig :
{% set header_image_media = page.media.videos|first %} {{ header_image_media.loop(true).autoplay(true).controls(false).poster("/path/to/image").html() }}