[Bug Fix] - Markdown Processing for Telephone Links #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge recent upstream changes
Telephone links use the `+` character to specify a country code, but Grav was replacing the `+` with a space character.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey All,
Telephone link URLs use the
+character to specify a globally unique number. However, when Grav parses a markdown telephone link, it replaces any+characters with spaces.For example,
[Call us](tel:+15551231234)becomes<a href="tel: 15551231234">Call us</a>This replacement is happening because
inlineLinkinParsedownGravTraitcallsprocessLinkExcerpt, which then usesurldecodeon thehrefattribute -urldecodereplaces all+characters with spaces.This pull request attempts to solve the issue by simply changing the call to
urldecodetorawurldecode.rawurldecodeworks the same asurldecode, except that it does not replace+characters.