Method $pages->find()
should never redirect
#3266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix some redirect issues in $pages->find()` method.
It attempts to keep the old behavior with one exception:
dispatch()
will attempt to find the regexp routes before redirects, which makes more sense than the old behavior.I have not changed how the blind redirects work (defined in
site.redirects
configuration), IMHO they should take the path as it is and route accordingly. If you want to redirect a path to an existing page, it's better to usesite.routes
instead and force redirect by settingsystem.pages.redirect_default_route
to 301/302 instead.CC: #3004, #2435