Enhancement: Add service discovery support for multiple homepage instances

[timo95]

Proposed change

Adds support for scoping docker labels to specific homepage instances.

To limit a label to an instance, insert .instance.{{instanceName}} after the homepage prefix.

labels:
  - homepage.group=Media
  - homepage.name=Emby
  - homepage.icon=emby.png
  - homepage.instance.internal.href=http://emby.lan/
  - homepage.instance.public.href=https://emby.mydomain.com/
  - homepage.description=Media server

In this example it is used with two homepage instances for internal and public access.

Type of change

• New service widget
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation only
• Other (please explain)

Checklist:

• If adding a service widget or a change that requires it, I have added corresponding documentation changes.
• If adding a new widget I have reviewed the guidelines.
• I have checked that all code style checks pass using pre-commit hooks and linting checks with pnpm lint (see development guidelines).
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

Do you really need the .instance. part?

[timo95]

It prevents ambiguity and collisions with existing options. Without, you would have to compare to each possible option name to know, if it's an instance name or just an option.

  - homepage.public.name:

How would it know, if this is an instance name or just a new homepage option.

[shamoon]

Ah, yea I guess I see youre using it to allow some global settings and some instance settings.

Has this been requested?

[timo95]

#1261

I think I saw a similar request on discord too.

[shamoon]

Gotcha thanks. We’ll take a look when we can, looks good from my phone :)

[shamoon]

I like this and it works well in my testing, allows for more than just e.g. changing an href, you can of course completely change a group, icon, whatever between two instances (have to say, in general Im not a two-instances fan, but thats my problem).

I debated the naming scheme a bit but I think thats just pedantic, this isnt so out of line with typical docker label conventions.

Thanks for the PR

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.